Box block, VariantProps fix #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +104 B (0%) Total Size: 277 kB
ℹ️ View Unchanged
|
shawnbot
commented
Feb 9, 2023
Comment on lines
+18
to
+19
| // FIXME[1.0]: remove this alias | ||
| export type FlexVariant = FlexProps |
There was a problem hiding this comment.
FlexVariant was a typo 😭 so I'm adding FlexProps and aliasing it to FlexVariant so that we don't have to release this as a breaking change. The FIXME[1.0] comment should remind us to remove the alias when we release 1.0.
joni-f-g
reviewed
Feb 14, 2023
| import React, { Component, ComponentProps, ComponentType } from 'react' | ||
| import React, { ComponentProps, ComponentType } from 'react' | ||
|
|
||
| // XXX: export type { VariantProps } from '@stitches/react' |
There was a problem hiding this comment.
should we just delete this? also, I think I'm confused on whether the stitches VariantProps is working or causing issues. but down to merge this and see if it fixes the linting errors
There was a problem hiding this comment.
I don't know, tbh. It doesn't hurt to keep the comment around as a reminder that we could bring back the stitches type if/when it's fixed upstream, though.
joni-f-g
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things:
display: blockin the default styles for<Box>, which simplifies<Box as='a'>or any other element that isn't block-level by default.VariantPropstype with the one from Stitches. Let's see if this improves autocompletion and errors with theasprop in sfgov-next. 🤞